create pvs in crc #540

mgirgisf · 2023-11-21T15:07:33Z

Depends-On: openstack-k8s-operators/install_yamls#642

softwarefactory-project-zuul · 2023-11-21T15:22:27Z

Unable to freeze job graph: Job pvs_crc is abstract and may not be directly run

.zuul.yaml

elfiesmelfie · 2023-11-21T16:13:22Z

.zuul.yaml

        - stf-crc-ocp_412-nightly_bundles
        - stf-crc-ocp_412-local_build
        - stf-crc-ocp_413-nightly_bundles


These jobs take quite a while to run.

For testing, I recommend that you comment them out so that you can get results faster from the pvs_crc job.

Suggested change

- stf-crc-ocp_412-nightly_bundles

- stf-crc-ocp_412-local_build

- stf-crc-ocp_413-nightly_bundles

#- stf-crc-ocp_412-nightly_bundles

#- stf-crc-ocp_412-local_build

#- stf-crc-ocp_413-nightly_bundles

elfiesmelfie · 2023-11-21T16:21:30Z

ci/define_pvs.yml

+    - name: Check if make command exists
+      ansible.builtin.command: "command -v make"
+      register: make_check_result
+      ignore_errors: true
+
+    - name: Install make if not present
+      ansible.builtin.package:
+        name: make
+        state: present
+      when: make_check_result.rc != 0


The package module should only install make if it doesn't already exist.
So this check and when are not needed

Suggested change

- name: Check if make command exists

ansible.builtin.command: "command -v make"

register: make_check_result

ignore_errors: true

- name: Install make if not present

ansible.builtin.package:

name: make

state: present

when: make_check_result.rc != 0

- name: Install make if not present

ansible.builtin.package:

name: make

state: present

I forgot that, thanks emma 😅

elfiesmelfie · 2023-11-21T16:39:05Z

ci/define_pvs.yml

+        cmd: |
+          oc get pv | grep "storage..-crc"| wc -l
+      register: cmd_output
+      failed_when: "cmd_output.stdout|int !=12"


I'd like to see some output here as well e.g. a debug.
You can use the ansible.builtin.fail module to check cmd_output.stdout_lines | length

Since we don't control the creation of the PVs, I would revise this test, since the number of lines may change without changing the PVs, for example.

IINM, we want to be able to use the PVs in the {{ namespace }} namespace/project [1], so there should be a check for that.

[1]

service-telemetry-operator/ci/vars-zuul-common.yml

Line 2 in 77dea87

namespace: "service-telemetry"

yes , this is not the final test , I believe I still need to create pvc to be used directly in the pods this create only the pvs , but wanted to check how the zuul will run it , so I created it as a draft pull request but this is not done yet

softwarefactory-project-zuul · 2023-11-21T16:52:09Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b69bb1fdcfe84af1b78604af80277615

❌ pvs_crc FAILURE in 10m 39s
✔️ stf-crc-ocp_412-nightly_bundles SUCCESS in 23m 11s
✔️ stf-crc-ocp_412-local_build SUCCESS in 35m 39s
✔️ stf-crc-ocp_413-nightly_bundles SUCCESS in 26m 51s
✔️ stf-crc-ocp_413-local_build SUCCESS in 38m 48s

softwarefactory-project-zuul · 2023-11-22T07:49:21Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/4f157b25913c4115baa90329487919fd

❌ pvs_crc FAILURE in 7m 53s

elfiesmelfie · 2023-11-24T14:30:05Z

ci/define_pvs.yml

+        name: rhol_crc
+        tasks_from: add_crc_creds.yml
+
+    - name: "Check if the install_yamls already exists"


Best practice with zuul is to never clone anything in your jobs.

You can configure zuul to clone the required repos as part of the job setup.
This is done in .zuul.yaml in the required-projects section of the job (in this case, the parent stf-base)
Once a project is cloned, it is available at {{ ansible_env.HOME }}/{{ zuul.projects[<fully qualified project name>].src_dir }}
You can see examples of this in ci/vars-zuul-common.yml.

The projects you can include are listed in rdo/config repo [2].
In this case, the relevant section is in [3] and the fully-qualified project name is github.com/openstack-k8s-operators/install_yamls, which will also be used in .zuul.yaml to tell zuul to include that project.

[1] https://review.rdoproject.org/zuul/build/62079c915ab846b99f1cffc83a4b97f9/log/zuul-info/inventory.yaml
[2] https://review.rdoproject.org/cgit/config/tree/zuul/rdo.yaml
[3] https://review.rdoproject.org/cgit/config/tree/zuul/rdo.yaml#n1231

I can't comment on an unchanged line, the required project should be added after line 14 in .zuul.yaml.

By default, zuul will try to check out the same branch name (i.e. master), but install_yamls does not have this branch, so you'll also need the override-checkout as well as the name for install_yamls.

https://zuul-ci.org/docs/zuul/latest/config/job.html#attr-job.required-projects

softwarefactory-project-zuul · 2023-11-27T08:59:52Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/service-telemetry-operator for 540,37f8c94a996c3c1c3547cded0fdb59a26a2720fe

softwarefactory-project-zuul · 2023-11-27T10:57:47Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/86321430a94047bcadb774ce17edd271

❌ pvs_crc FAILURE in 9m 14s
❌ stf-crc-ocp_413-local_build TIMED_OUT in 1h 01m 01s

softwarefactory-project-zuul · 2023-11-27T12:23:12Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/fb058c56b2ac4ab3a0f94a70590a9787

✔️ pvs_crc SUCCESS in 10m 19s
❌ stf-crc-ocp_413-local_build TIMED_OUT in 1h 00m 55s

elfiesmelfie · 2023-11-30T10:56:27Z

ci/vars-local_build.yml

@@ -2,4 +2,5 @@
 __deploy_stf: true
 __local_build_enabled: true
 __service_telemetry_snmptraps_enabled: true
-__service_telemetry_storage_ephemeral_enabled: true
+__service_telemetry_storage_ephemeral_enabled: false
+__service_telemetry_storage_persistent_storage_class: "crc_storage"


nit: This should be in ci/vars-zuul-common.yml

elfiesmelfie · 2023-11-30T10:59:12Z

ci/vars-zuul-common.yml

@@ -9,3 +9,5 @@ sgo_dir: "{{ ansible_env.HOME }}/{{ zuul.projects['github.com/infrawatch/smart-g
 sg_core_dir: "{{ ansible_env.HOME }}/{{ zuul.projects['github.com/infrawatch/sg-core'].src_dir }}"
 sg_bridge_dir: "{{ ansible_env.HOME }}/{{ zuul.projects['github.com/infrawatch/sg-bridge'].src_dir }}"
 prometheus_webhook_snmp_dir: "{{ ansible_env.HOME }}/{{ zuul.projects['github.com/infrawatch/prometheus-webhook-snmp'].src_dir }}"
+install_yamls_dir: "{{ ansible_env.HOME }}/{{ zuul.projects['github.com/openstack-k8s-operators/install_yamls'].src_dir }}"
+__service_telemetry_storage_persistent_storage_class: "crc-storage"


Typo. In vars-local_build, you used an underscore.

Both should be the same.

elfiesmelfie · 2023-11-30T11:05:28Z

recheck

softwarefactory-project-zuul · 2023-11-30T12:10:20Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1e65b26b418141d1b4bede4d6197dede

✔️ pvs_crc SUCCESS in 10m 04s
❌ stf-crc-ocp_413-local_build TIMED_OUT in 1h 01m 00s

softwarefactory-project-zuul · 2023-12-01T09:11:06Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/280dda5bb8c3403e93472be579d856ba

✔️ pvs_crc SUCCESS in 8m 41s
❌ stf-crc-ocp_413-local_build TIMED_OUT in 1h 00m 58s

softwarefactory-project-zuul · 2023-12-01T15:19:51Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/790c87af09894727b7f658767061db67

✔️ pvs_crc SUCCESS in 10m 08s
❌ stf-crc-ocp_413-local_build FAILURE in 21m 06s

softwarefactory-project-zuul · 2023-12-04T06:48:41Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/55fab1ab277e4c45a6060368335bbd44

✔️ pvs_crc SUCCESS in 12m 12s
❌ stf-crc-ocp_413-local_build FAILURE in 1h 00m 25s

mgirgisf added 2 commits November 21, 2023 16:06

create pvs in crc

5309862

add job in project-template

e69b087

mgirgisf added 5 commits November 21, 2023 16:23

remove abstract

7e7fb10

change the name

1f07ec5

add builtin

c37b87a

update parent job

c3d1ec8

add correct path

190e583

elfiesmelfie requested changes Nov 21, 2023

View reviewed changes

update playbook

0947f69

make update to install package

10d468f

elfiesmelfie reviewed Nov 24, 2023

View reviewed changes

update the default storage_class

37f8c94

mgirgisf and others added 3 commits November 27, 2023 10:02

Merge branch 'master' into mgirgis_STF-1626_PVsToCrc

399387a

add storage_class

35e5cba

missing quotes

b65d166

change the storage name

220f339

elfiesmelfie requested changes Nov 30, 2023

View reviewed changes

increase storage capacity

678c6fa

mgirgisf added 3 commits December 1, 2023 15:25

update the capacity

fa75108

reduce the capacity

0890b9c

remove get list

2e21bb6

test different capacity

c06d4c6

mgirgisf closed this Dec 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

create pvs in crc #540

create pvs in crc #540

mgirgisf commented Nov 21, 2023 •

edited by elfiesmelfie

Loading

softwarefactory-project-zuul bot commented Nov 21, 2023

elfiesmelfie Nov 21, 2023

elfiesmelfie Nov 21, 2023

mgirgisf Nov 22, 2023

elfiesmelfie Nov 21, 2023

elfiesmelfie Nov 21, 2023

mgirgisf Nov 22, 2023

softwarefactory-project-zuul bot commented Nov 21, 2023

softwarefactory-project-zuul bot commented Nov 22, 2023

elfiesmelfie Nov 24, 2023

elfiesmelfie Nov 24, 2023

softwarefactory-project-zuul bot commented Nov 27, 2023

softwarefactory-project-zuul bot commented Nov 27, 2023

softwarefactory-project-zuul bot commented Nov 27, 2023

elfiesmelfie Nov 30, 2023

elfiesmelfie Nov 30, 2023

elfiesmelfie commented Nov 30, 2023

softwarefactory-project-zuul bot commented Nov 30, 2023

softwarefactory-project-zuul bot commented Dec 1, 2023

softwarefactory-project-zuul bot commented Dec 1, 2023

softwarefactory-project-zuul bot commented Dec 4, 2023

create pvs in crc #540

create pvs in crc #540

Conversation

mgirgisf commented Nov 21, 2023 • edited by elfiesmelfie Loading

softwarefactory-project-zuul bot commented Nov 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Nov 21, 2023

softwarefactory-project-zuul bot commented Nov 22, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Nov 27, 2023

softwarefactory-project-zuul bot commented Nov 27, 2023

softwarefactory-project-zuul bot commented Nov 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elfiesmelfie commented Nov 30, 2023

softwarefactory-project-zuul bot commented Nov 30, 2023

softwarefactory-project-zuul bot commented Dec 1, 2023

softwarefactory-project-zuul bot commented Dec 1, 2023

softwarefactory-project-zuul bot commented Dec 4, 2023

mgirgisf commented Nov 21, 2023 •

edited by elfiesmelfie

Loading