Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added in Mik's changes and an update to the README as well. #324

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Added in Mik's changes and an update to the README as well. #324

merged 4 commits into from
Dec 21, 2023

Conversation

RyanProffitt
Copy link
Contributor

Making some change to how the example code handles which API to hit.

@RyanProffitt RyanProffitt self-assigned this Dec 21, 2023
Vui-Chee
Vui-Chee reviewed Dec 21, 2023
View reviewed changes
Copy link

@Vui-Chee Vui-Chee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if you forget to specify the port in the URL? Do you really want to specify the port or can have that separately?

@RyanProffitt RyanProffitt merged commit 27c67cb into master Dec 21, 2023
4 checks passed
@RyanProffitt RyanProffitt deleted the endpoint-switch branch December 21, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieCrisman JamieCrisman JamieCrisman left review comments

@Vui-Chee Vui-Chee Vui-Chee approved these changes

Assignees

@RyanProffitt RyanProffitt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanProffitt @JamieCrisman @Vui-Chee