Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(code/starknet): Change signature scheme from ECDSA to Ed25519 #871

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

romac
Copy link
Member

@romac romac commented Feb 21, 2025

Closes: #XXX


PR author checklist

For all contributors

For external contributors

@romac romac requested a review from ancazamfir as a code owner February 21, 2025 09:02
@romac romac changed the base branch from main to anca/starknet_interop February 21, 2025 09:02
@romac romac changed the base branch from anca/starknet_interop to main February 21, 2025 09:03
@romac
Copy link
Member Author

romac commented Feb 21, 2025

@ancazamfir Should I rather target this PR to #868 or do we merge to main directly?

@romac romac force-pushed the romac/starknet-ed25519 branch from 71e20c6 to 6533ec6 Compare February 21, 2025 13:19
@romac romac force-pushed the romac/starknet-ed25519 branch from 6533ec6 to 34b0d8e Compare February 21, 2025 13:49
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.31%. Comparing base (486f9cf) to head (bd42b53).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
+ Coverage   82.06%   82.31%   +0.25%     
==========================================
  Files         188      187       -1     
  Lines       16102    16060      -42     
==========================================
+ Hits        13214    13219       +5     
+ Misses       2888     2841      -47     
Flag Coverage Δ
integration 82.16% <ø> (+0.22%) ⬆️
mbt 8.43% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core ∅ <ø> (∅)
engine ∅ <ø> (∅)
app ∅ <ø> (∅)
starknet ∅ <ø> (∅)

@ancazamfir
Copy link
Collaborator

@ancazamfir Should I rather target this PR to #868 or do we merge to main directly?

I think this one can go to main.

Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@romac romac enabled auto-merge February 21, 2025 15:36
@romac romac added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 52ee8df Feb 21, 2025
18 checks passed
@romac romac deleted the romac/starknet-ed25519 branch February 21, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants