-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(code/starknet): Change signature scheme from ECDSA to Ed25519 #871
Conversation
@ancazamfir Should I rather target this PR to #868 or do we merge to main directly? |
71e20c6
to
6533ec6
Compare
6533ec6
to
34b0d8e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
==========================================
+ Coverage 82.06% 82.31% +0.25%
==========================================
Files 188 187 -1
Lines 16102 16060 -42
==========================================
+ Hits 13214 13219 +5
+ Misses 2888 2841 -47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I think this one can go to main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes: #XXX
PR author checklist
For all contributors
For external contributors