Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(code): Early check for sync actor presence #822

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

ancazamfir
Copy link
Collaborator

Closes: #XXX
Bits from initial work on #771


PR author checklist

For all contributors

For external contributors

@ancazamfir ancazamfir requested a review from romac as a code owner February 3, 2025 11:14
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (b17d82c) to head (130e9b4).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
- Coverage   75.81%   75.79%   -0.02%     
==========================================
  Files         169      169              
  Lines       14682    14682              
==========================================
- Hits        11130    11127       -3     
- Misses       3552     3555       +3     
Flag Coverage Δ
integration 75.48% <ø> (-0.02%) ⬇️
mbt 20.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core ∅ <ø> (∅)
engine ∅ <ø> (∅)
app ∅ <ø> (∅)
starknet ∅ <ø> (∅)

@ancazamfir ancazamfir added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit 22c7a44 Feb 3, 2025
22 checks passed
@ancazamfir ancazamfir deleted the anca/sync_check branch February 3, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants