Skip to content
Rust

Repo reorg phase-2 #1

Sign in to view logs

Repo reorg phase-2

Repo reorg phase-2 #1

GitHub Actions / clippy succeeded May 21, 2024 in 0s

clippy

19 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 19
Note 0
Help 0

Versions

  • rustc 1.78.0 (9b00956e5 2024-04-29)
  • cargo 1.78.0 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9b00956 2024-04-29)

Annotations

Check warning on line 320 in utils/mtcs-intent/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value 

warning: used `unwrap()` on a `Result` value
   --> utils/mtcs-intent/src/main.rs:320:28
    |
320 |             println!("{}", AccountId::new("wasm", tm_pk.as_bytes()).unwrap());
    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 310 in utils/mtcs-intent/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value 

warning: used `unwrap()` on a `Result` value
   --> utils/mtcs-intent/src/main.rs:310:22
    |
310 |             let sk = XPrv::from_str(&sk_str).unwrap();
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 307 in utils/mtcs-intent/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value 

warning: used `unwrap()` on a `Result` value
   --> utils/mtcs-intent/src/main.rs:307:28
    |
307 |             println!("{}", AccountId::new("wasm", tm_pk.as_bytes()).unwrap());
    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 298 in utils/mtcs-intent/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value 

warning: used `unwrap()` on a `Result` value
   --> utils/mtcs-intent/src/main.rs:298:26
    |
298 |             let setoff = decrypt(&sk.to_bytes(), &ciphertext).unwrap();
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 296 in utils/mtcs-intent/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value 

warning: used `unwrap()` on a `Result` value
   --> utils/mtcs-intent/src/main.rs:296:30
    |
296 |             let ciphertext = hex::decode(setoff).unwrap();
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 276 in utils/mtcs-intent/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value 

warning: used `unwrap()` on a `Result` value
   --> utils/mtcs-intent/src/main.rs:276:17
    |
276 |                 d.try_into().unwrap()
    |                 ^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 255 in utils/mtcs-intent/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value 

warning: used `unwrap()` on a `Result` value
   --> utils/mtcs-intent/src/main.rs:255:25
    |
255 |                 let o = decrypt(&sk.to_bytes(), &ciphertext).unwrap();
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 252 in utils/mtcs-intent/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value 

warning: used `unwrap()` on a `Result` value
   --> utils/mtcs-intent/src/main.rs:252:30
    |
252 |             let ciphertext = hex::decode(obligation).unwrap();
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
note: the lint level is defined here
   --> utils/mtcs-intent/src/main.rs:6:5
    |
6   |     clippy::unwrap_used,
    |     ^^^^^^^^^^^^^^^^^^^

Check warning on line 320 in utils/mtcs-intent/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value 

warning: used `unwrap()` on a `Result` value
   --> utils/mtcs-intent/src/main.rs:320:28
    |
320 |             println!("{}", AccountId::new("wasm", tm_pk.as_bytes()).unwrap());
    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 310 in utils/mtcs-intent/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value 

warning: used `unwrap()` on a `Result` value
   --> utils/mtcs-intent/src/main.rs:310:22
    |
310 |             let sk = XPrv::from_str(&sk_str).unwrap();
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 307 in utils/mtcs-intent/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value 

warning: used `unwrap()` on a `Result` value
   --> utils/mtcs-intent/src/main.rs:307:28
    |
307 |             println!("{}", AccountId::new("wasm", tm_pk.as_bytes()).unwrap());
    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 298 in utils/mtcs-intent/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value 

warning: used `unwrap()` on a `Result` value
   --> utils/mtcs-intent/src/main.rs:298:26
    |
298 |             let setoff = decrypt(&sk.to_bytes(), &ciphertext).unwrap();
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 296 in utils/mtcs-intent/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value 

warning: used `unwrap()` on a `Result` value
   --> utils/mtcs-intent/src/main.rs:296:30
    |
296 |             let ciphertext = hex::decode(setoff).unwrap();
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 276 in utils/mtcs-intent/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value 

warning: used `unwrap()` on a `Result` value
   --> utils/mtcs-intent/src/main.rs:276:17
    |
276 |                 d.try_into().unwrap()
    |                 ^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 255 in utils/mtcs-intent/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value 

warning: used `unwrap()` on a `Result` value
   --> utils/mtcs-intent/src/main.rs:255:25
    |
255 |                 let o = decrypt(&sk.to_bytes(), &ciphertext).unwrap();
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used

Check warning on line 252 in utils/mtcs-intent/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used `unwrap()` on a `Result` value 

warning: used `unwrap()` on a `Result` value
   --> utils/mtcs-intent/src/main.rs:252:30
    |
252 |             let ciphertext = hex::decode(obligation).unwrap();
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: if this value is an `Err`, it will panic
    = help: consider using `expect()` to provide a better panic message
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
note: the lint level is defined here
   --> utils/mtcs-intent/src/main.rs:6:5
    |
6   |     clippy::unwrap_used,
    |     ^^^^^^^^^^^^^^^^^^^

Check warning on line 95 in utils/cycles-sync/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you are explicitly cloning with `.map()` 

warning: you are explicitly cloning with `.map()`
  --> utils/cycles-sync/src/main.rs:93:48
   |
93 |                   let (debtor_id, creditor_id) = obligation_user_map
   |  ________________________________________________^
94 | |                     .get(obligation_digest)
95 | |                     .map(Clone::clone)
   | |______________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
   = note: `#[warn(clippy::map_clone)]` on by default
help: consider calling the dedicated `copied` method
   |
93 ~                 let (debtor_id, creditor_id) = obligation_user_map
94 +                     .get(obligation_digest).copied()
   |

Check warning on line 328 in utils/cycles-sync/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits 

warning: the borrowed expression implements the required traits
   --> utils/cycles-sync/src/main.rs:328:41
    |
328 |         let mnemonic = Mnemonic::random(&mut OsRng, Default::default());
    |                                         ^^^^^^^^^^ help: change this to: `OsRng`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

Check warning on line 95 in utils/cycles-sync/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you are explicitly cloning with `.map()` 

warning: you are explicitly cloning with `.map()`
  --> utils/cycles-sync/src/main.rs:93:48
   |
93 |                   let (debtor_id, creditor_id) = obligation_user_map
   |  ________________________________________________^
94 | |                     .get(obligation_digest)
95 | |                     .map(Clone::clone)
   | |______________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
   = note: `#[warn(clippy::map_clone)]` on by default
help: consider calling the dedicated `copied` method
   |
93 ~                 let (debtor_id, creditor_id) = obligation_user_map
94 +                     .get(obligation_digest).copied()
   |
View more details on GitHub Actions