DCAP cert validation tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amiller
approved these changes
May 28, 2024
There was a problem hiding this comment.
I walked through this to explain w/ poetic and it all made sense.
The upstream mobilecoin used mbedtls, but we are aiming to avoid that by using a cosmwasm x509 library as alternative. So these tests will pass once we instantiate the x509 certificate chain checker
hu55a1n1
force-pushed
the
hu55a1n1/dcap-cert-validation
branch
from
acf3a1c
to
7ddb328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faliing tests for DCAP cert validation.
All tests are currently ignored. To run a single test e.g.
evidence_verifier_succeeds_with_mbedtls_x509_verifier, comment the#[ignore]on it and run ->(Tests are currently panicking because of the
todo!()here)