-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hermes config generator #230
feat: hermes config generator #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments this looks great tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I left some final questions. But I think after you answer those we should just merge this (I don't want it this to get stuck in review forever).
This looks great and is an amazing improvement over the existing modules. Thank you so much!
Co-authored-by: Jonathan Lorimer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing. Thanks so much @dzmitry-lahoda
works for me here https://github.com/ComposableFi/nix . also this is kind of design for reusable kind of devnet bash scripts. etc. |
partially fixed test, gaia fails with nil pointer (go is go).