Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hermes config generator #230

Merged
merged 12 commits into from
Mar 19, 2024

Conversation

dzmitry-lahoda
Copy link
Collaborator

partially fixed test, gaia fails with nil pointer (go is go).

@dzmitry-lahoda dzmitry-lahoda requested a review from romac March 18, 2024 14:20
Copy link
Collaborator

@JonathanLorimer JonathanLorimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments this looks great tho

nixosTests/tests/hermes-test.nix Outdated Show resolved Hide resolved
nixosTests/tests/hermes-test.nix Show resolved Hide resolved
nixosModules/hermes/default.nix Outdated Show resolved Hide resolved
nixosModules/hermes/default.nix Outdated Show resolved Hide resolved
nixosModules/hermes/default.nix Outdated Show resolved Hide resolved
nixosModules/hermes/default.nix Outdated Show resolved Hide resolved
nixosModules/hermes/chain-options.nix Show resolved Hide resolved
modules/nixosModules.nix Show resolved Hide resolved
lib/default.nix Show resolved Hide resolved
@dzmitry-lahoda dzmitry-lahoda requested a review from romac March 18, 2024 19:21
Copy link
Collaborator

@JonathanLorimer JonathanLorimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more comments

lib/default.nix Outdated Show resolved Hide resolved
nixosModules/hermes/chain-options.nix Show resolved Hide resolved
nixosModules/hermes/default.nix Outdated Show resolved Hide resolved
nixosModules/hermes/default.nix Outdated Show resolved Hide resolved
Copy link
Collaborator

@JonathanLorimer JonathanLorimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I left some final questions. But I think after you answer those we should just merge this (I don't want it this to get stuck in review forever).

This looks great and is an amazing improvement over the existing modules. Thank you so much!

nixosModules/hermes/base.nix Show resolved Hide resolved
lib/default.nix Outdated Show resolved Hide resolved
nixosModules/hermes/default.nix Show resolved Hide resolved
Co-authored-by: Jonathan Lorimer <[email protected]>
Copy link
Collaborator

@JonathanLorimer JonathanLorimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing. Thanks so much @dzmitry-lahoda

@dzmitry-lahoda dzmitry-lahoda merged commit dc09dd9 into informalsystems:main Mar 19, 2024
2 checks passed
@dzmitry-lahoda
Copy link
Collaborator Author

works for me here https://github.com/ComposableFi/nix . also this is kind of design for reusable kind of devnet bash scripts. etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants