Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use human-readable secret key for local OAB #2793

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

hsiliev
Copy link
Collaborator

@hsiliev hsiliev commented Feb 27, 2025

Replace hashed secret key with human readable one

Solves: PZ-5706

Replace hashed secret key with human readable one

Solves: PZ-5706
@hsiliev hsiliev requested a review from a team as a code owner February 27, 2025 15:07
@hsiliev hsiliev enabled auto-merge February 27, 2025 15:08
Copy link
Contributor

unit-test-results

 86 files  ±0  124 suites  ±0   1m 42s ⏱️ -1s
475 tests ±0  474 ✅ ±0  1 💤 ±0  0 ❌ ±0 
579 runs  ±0  577 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 7809e08. ± Comparison against base commit 97fde12.

Copy link
Contributor

integration-test-results

 31 files  ±0   31 suites  ±0   41s ⏱️ ±0s
114 tests ±0  114 ✅ ±0  0 💤 ±0  0 ❌ ±0 
127 runs  ±0  127 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7809e08. ± Comparison against base commit 97fde12.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.18%. Comparing base (97fde12) to head (7809e08).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2793   +/-   ##
=========================================
  Coverage     42.18%   42.18%           
  Complexity     3479     3479           
=========================================
  Files          1334     1334           
  Lines         32258    32258           
  Branches       2975     2975           
=========================================
  Hits          13608    13608           
  Misses        17829    17829           
  Partials        821      821           
Flag Coverage Δ
integrationtests 51.41% <ø> (ø)
unittests 28.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hsiliev hsiliev added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit f3d94be Feb 27, 2025
21 checks passed
@hsiliev hsiliev deleted the fix/PZ-5706-human-readable-oab-secret branch February 27, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants