Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unneeded setting of client_id for ZAC abonnement in Open Notificaties Docker Compose #2791

Conversation

edgarvonk
Copy link
Member

Remove unneeded setting of client_id for ZAC abonnement in Open Notificaties Docker Compose as the client_id field is not used anymore by OpenNotificaties. Somewhat related to open-zaak/open-zaak#1694

Solves PZ-5701

@edgarvonk edgarvonk requested review from hsiliev and a team as code owners February 27, 2025 12:42
Copy link
Contributor

unit-test-results

 86 files  ±0  124 suites  ±0   1m 44s ⏱️ -1s
475 tests ±0  474 ✅ ±0  1 💤 ±0  0 ❌ ±0 
579 runs  ±0  577 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 2f8845e. ± Comparison against base commit 2745c42.

Copy link
Contributor

integration-test-results

 31 files  ±0   31 suites  ±0   42s ⏱️ -1s
114 tests ±0  114 ✅ ±0  0 💤 ±0  0 ❌ ±0 
127 runs  ±0  127 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2f8845e. ± Comparison against base commit 2745c42.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.18%. Comparing base (2745c42) to head (2f8845e).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #2791    +/-   ##
==========================================
  Coverage     42.18%   42.18%            
  Complexity     3479     3479            
==========================================
  Files          1334     1334            
  Lines         32258    32258            
  Branches       2975     3035    +60     
==========================================
  Hits          13608    13608            
+ Misses        17829    17427   -402     
- Partials        821     1223   +402     
Flag Coverage Δ
integrationtests 51.41% <ø> (ø)
unittests 28.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarvonk edgarvonk enabled auto-merge February 27, 2025 13:57
@edgarvonk edgarvonk added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit 70a1136 Feb 27, 2025
21 checks passed
@edgarvonk edgarvonk deleted the feature/PZ-5701-remove-unneeded-setting-of-clientid-for-opennotificaties-in-docker-compose branch February 27, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants