Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Open Notificaties in Docker Compose setup #2780

Merged

Conversation

edgarvonk
Copy link
Member

Fix OpenNotificaties in Docker Compose setup for local testing. Includes a workaround for initialising the 'ZAC abonnement' in the OpenNotificaties database until OpenNotificaties support setting the client_id field in the YAML-based setup configuration.

Solves PZ-5591

@edgarvonk edgarvonk requested review from hsiliev and a team as code owners February 26, 2025 15:34
@edgarvonk edgarvonk changed the title Feature/pz 5591 fix open notificaties in docker compose feat: fix open notificaties in docker compose Feb 26, 2025
@edgarvonk edgarvonk changed the title feat: fix open notificaties in docker compose fix: fix Open Notificaties in Docker Compose setup Feb 26, 2025
Copy link
Contributor

unit-test-results

 85 files  ±0  123 suites  ±0   1m 45s ⏱️ -1s
474 tests ±0  473 ✅ ±0  1 💤 ±0  0 ❌ ±0 
577 runs  ±0  575 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 86e11f8. ± Comparison against base commit baf4bfe.

Copy link
Contributor

integration-test-results

 31 files  ±0   31 suites  ±0   40s ⏱️ ±0s
114 tests ±0  114 ✅ ±0  0 💤 ±0  0 ❌ ±0 
127 runs  ±0  127 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 86e11f8. ± Comparison against base commit baf4bfe.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.16%. Comparing base (baf4bfe) to head (86e11f8).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #2780    +/-   ##
==========================================
  Coverage     42.16%   42.16%            
  Complexity     3476     3476            
==========================================
  Files          1336     1336            
  Lines         32271    32271            
  Branches       3046     3045     -1     
==========================================
  Hits          13608    13608            
- Misses        17440    17842   +402     
+ Partials       1223      821   -402     
Flag Coverage Δ
integrationtests 51.38% <ø> (ø)
unittests 28.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarvonk edgarvonk enabled auto-merge February 26, 2025 16:01
@edgarvonk edgarvonk added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit ab6e069 Feb 26, 2025
22 of 23 checks passed
@edgarvonk edgarvonk deleted the feature/PZ-5591-fix-open-notificaties-in-docker-compose branch February 26, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants