Skip to content

Commit

Permalink
Updates for go client PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
@shadtimm
shadtimm committed Mar 21, 2022
1 parent 3ce18a3 commit 274f25e
Show file tree
Hide file tree
Showing 7 changed files with 38 additions and 35 deletions.
2 changes: 1 addition & 1 deletion go.mod
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ require (
golang.org/x/sys v0.0.0-20210510120138-977fb7262007 // indirect
)

replace github.com/infobloxopen/infoblox-go-client/v2 => github.com/shadtimm/infoblox-go-client/v2 v2.2.0-beta
replace github.com/infobloxopen/infoblox-go-client/v2 => github.com/shadtimm/infoblox-go-client/v2 v2.2.0-beta2
6 changes: 2 additions & 4 deletions go.sum
View file
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,6 @@ github.com/hpcloud/tail v1.0.0/go.mod h1:ab1qPbhIpdTxEkNHXyeSf5vhxWSCs/tWer42PpO
github.com/ianlancetaylor/demangle v0.0.0-20181102032728-5e5cf60278f6/go.mod h1:aSSvb/t6k1mPoxDqO4vJh6VOCGPwU4O0C2/Eqndh1Sc=
github.com/imdario/mergo v0.3.9 h1:UauaLniWCFHWd+Jp9oCEkTBj8VO/9DKg3PV3VCNMDIg=
github.com/imdario/mergo v0.3.9/go.mod h1:2EnlNZ0deacrJVfApfmtdGgDfMuh/nq6Ok1EcJh5FfA=
github.com/infobloxopen/infoblox-go-client/v2 v2.1.0 h1:ND1OaE8MUm51YdJoM5tDyJ+Bs20+wwUqxEzv+eXkotg=
github.com/infobloxopen/infoblox-go-client/v2 v2.1.0/go.mod h1:+lznx4ASBSUZ2i6qwlgyn0v3eKDxBHNU5aRJzghAFbw=
github.com/jbenet/go-context v0.0.0-20150711004518-d14ea06fba99 h1:BQSFePA1RWJOlocH6Fxy8MmwDt+yVQYULKfN0RoTN8A=
github.com/jbenet/go-context v0.0.0-20150711004518-d14ea06fba99/go.mod h1:1lJo3i6rXxKeerYnT8Nvf0QmHCRC1n8sfWVwXF2Frvo=
github.com/jessevdk/go-flags v1.4.0/go.mod h1:4FA24M0QyGHXBuZZK/XkWh8h0e1EYbRYJSGM75WSRxI=
Expand Down Expand Up @@ -284,8 +282,8 @@ github.com/rogpeppe/go-internal v1.3.0/go.mod h1:M8bDsm7K2OlrFYOpmOWEs/qY81heoFR
github.com/sergi/go-diff v1.0.0/go.mod h1:0CfEIISq7TuYL3j771MWULgwwjU+GofnZX9QAmXWZgo=
github.com/sergi/go-diff v1.1.0 h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
github.com/sergi/go-diff v1.1.0/go.mod h1:STckp+ISIX8hZLjrqAeVduY0gWCT9IjLuqbuNXdaHfM=
github.com/shadtimm/infoblox-go-client/v2 v2.2.0-beta h1:9idEdzoGcK6UraFdKpoAqWMRwrnyID9FphbT0xA9Fx4=
github.com/shadtimm/infoblox-go-client/v2 v2.2.0-beta/go.mod h1:+lznx4ASBSUZ2i6qwlgyn0v3eKDxBHNU5aRJzghAFbw=
github.com/shadtimm/infoblox-go-client/v2 v2.2.0-beta2 h1:1Wr3BoBq+aRFuQ52318E/JhYYR2UoTJnGWJuph/gMkI=
github.com/shadtimm/infoblox-go-client/v2 v2.2.0-beta2/go.mod h1:+lznx4ASBSUZ2i6qwlgyn0v3eKDxBHNU5aRJzghAFbw=
github.com/sirupsen/logrus v1.8.0 h1:nfhvjKcUMhBMVqbKHJlk5RPrrfYr/NMo3692g0dwfWU=
github.com/sirupsen/logrus v1.8.0/go.mod h1:4GuYW9TZmE769R5STWrRakJc4UqQ3+QQ95fyz7ENv1A=
github.com/spf13/pflag v1.0.2/go.mod h1:DYY7MBk1bdzusC3SYhjObp+wFpr4gzcvqqNjLnInEg4=
Expand Down
6 changes: 3 additions & 3 deletions infoblox/resource_infoblox_txt_record.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,11 @@ func resourceTXTRecordCreate(d *schema.ResourceData, m interface{}) error {
objMgr := ibclient.NewObjectManager(connector, "Terraform", tenantID)

recordTXT, err := objMgr.CreateTXTRecord(
dnsView,
recordName,
text,
dnsView,
useTtl,
ttl,
useTtl,
comment,
extAttrs)
if err != nil {
Expand Down Expand Up @@ -183,7 +183,7 @@ func resourceTXTRecordUpdate(d *schema.ResourceData, m interface{}) error {

objMgr := ibclient.NewObjectManager(connector, "Terraform", tenantID)

recordTXTUpdated, err := objMgr.UpdateTXTRecord(d.Id(), recordName, text, useTtl, ttl, comment, extAttrs)
recordTXTUpdated, err := objMgr.UpdateTXTRecord(d.Id(), recordName, text, ttl, useTtl, comment, extAttrs)
if err != nil {
return fmt.Errorf("Updating of TXT Record from dns view %s failed : %s", dnsView, err.Error())
}
Expand Down
6 changes: 3 additions & 3 deletions vendor/github.com/infobloxopen/infoblox-go-client/v2/object_manager.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 15 additions & 10 deletions vendor/github.com/infobloxopen/infoblox-go-client/v2/object_manager_txt-record.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 12 additions & 12 deletions vendor/github.com/infobloxopen/infoblox-go-client/v2/objects.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions vendor/modules.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ github.com/hashicorp/terraform-plugin-sdk/v2/plugin
github.com/hashicorp/terraform-plugin-sdk/v2/terraform
# github.com/hashicorp/yamux v0.0.0-20181012175058-2f1d1f20f75d
github.com/hashicorp/yamux
# github.com/infobloxopen/infoblox-go-client/v2 v2.1.0 => github.com/shadtimm/infoblox-go-client/v2 v2.2.0-beta
# github.com/infobloxopen/infoblox-go-client/v2 v2.1.0 => github.com/shadtimm/infoblox-go-client/v2 v2.2.0-beta2
## explicit
github.com/infobloxopen/infoblox-go-client/v2
# github.com/jmespath/go-jmespath v0.0.0-20180206201540-c2b33e8439af
Expand Down Expand Up @@ -382,4 +382,4 @@ google.golang.org/protobuf/types/known/durationpb
google.golang.org/protobuf/types/known/emptypb
google.golang.org/protobuf/types/known/timestamppb
google.golang.org/protobuf/types/pluginpb
# github.com/infobloxopen/infoblox-go-client/v2 => github.com/shadtimm/infoblox-go-client/v2 v2.2.0-beta
# github.com/infobloxopen/infoblox-go-client/v2 => github.com/shadtimm/infoblox-go-client/v2 v2.2.0-beta2

0 comments on commit 274f25e

Please sign in to comment.