Add more general method to execute MultiRequests #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infoblox offers the possibility to do MultiRequests with it's API. This is a powerful feature to use.
However, the current go client does not correctly support this API. The parsing of the responses is to restricted as is.
This PR adds a method to execute any type of MultiRequest and parses the result into the least specific structure a response can have.
I'm not sure if this method should be added to the IBObjectManager interface as well or rather not cause it seems to be an underutilized/rudimentarily supported/used feature.
PS: I could need some support to add testcases for this type of request because I could not find any for the existing MultiRequest related method to use as an example to work with.