Add useful fields for Authoritative Zone resource #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2022
skudriavtsev
requested changes
Jan 13, 2023
| Ref string `json:"_ref,omitempty"` | ||
| Fqdn string `json:"fqdn,omitempty"` | ||
| View string `json:"view,omitempty"` | ||
| NsGroup string `json:"ns_group,omitempty"` |
There was a problem hiding this comment.
What about setting no NS groups for this zone (in UI: 'None' for 'Name Servers')? 'omitempty' option can prevent this.
There was a problem hiding this comment.
If I understand correctly, you mean a case where the end user would like to send empty string "" as the ns_group to explicitly set this field to nothing; if we omit this from marshaling when it is empty, on the Infoblox side it will attempt to set the default NS Group instead. Is that correct?
|
Hi @skudriavtsev thanks for the review and feedback! I've made most of the requested changes:
If we can resolve the last question about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #185.
This adds the following fields for the
ZoneAuthresource, so users can set a Nameserver Group or SOA TTLs when creating a new zone.ns_grouprestart_if_neededcommentsoa_default_ttlsoa_expiresoa_negative_ttlsoa_refreshsoa_retryThese are already present in the Infoblox NIOS API; this change exposes them here in the Go Client.