DEVOPS-28230 remove version validation #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewwells
reviewed
Sep 24, 2024
| By("Reconciling the created resource") | ||
|
|
||
| _, err := controllerReconciler.Reconcile(ctx, reconcile.Request{NamespacedName: typeNamespacedName}) | ||
| Expect(err).To(MatchError(".spec.dbVersion is a mandatory field and cannot be empty")) | ||
| Expect(err).NotTo(HaveOccurred()) |
There was a problem hiding this comment.
Probably better to still have some sort of error here. I believe the idea of this set of tests is to verify dbclaims update and can be fixed by changing their values. What can we do to continue to simulate that error MajorVersion 12? Invalid database type?
| return false | ||
| } | ||
| return activeVersion != p.EngineVersion | ||
| return strings.Split(activeVersion, ".")[0] != strings.Split(p.DBVersion, ".")[0] |
There was a problem hiding this comment.
unsafe use of indexing a slice. Maybe make a type, there's a lot of comparisons going around here
type Version struct {
Major, Minor string
}
v := Version{Major:"15", "Minor: "3"}
return cmp.Equal(v.Major, "15")
There was a problem hiding this comment.
this works if the string is "", "15" or "15.2"
looks ugly, but works
drewwells
approved these changes
Sep 30, 2024
EvertonCalgarotto
deleted the
DEVOPS-28230-remove-version-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If NEW Claim and DBVersion="" version 15 is used instead
If EXISTING Claim and DBVersion= "" then version from Status.ActiveDB is used