Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(outputs.mqtt): Add sprig functions for topic name generator #15943

Merged
merged 2 commits into from
Oct 15, 2024
Merged

feat(outputs.mqtt): Add sprig functions for topic name generator #15943

merged 2 commits into from
Oct 15, 2024

Conversation

diorcety
Copy link
Contributor

Summary

Simple minor improvement allow to use sprig functions inside topic name templates

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@diorcety diorcety force-pushed the branch_output_mqtt_sprig branch 2 times, most recently from 2635a6e to 73a281e Compare September 27, 2024 14:03
@srebhan srebhan changed the title Add sprig for MQTT topic name generator feat(outputs.mqtt): Add sprig functions for topic name generator Sep 30, 2024
@telegraf-tiger telegraf-tiger bot added area/mqtt feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Sep 30, 2024
srebhan
srebhan reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @diorcety for your contribution. Just one style comment from my side...

plugins/outputs/mqtt/topic_name_generator.go Show resolved Hide resolved
@srebhan srebhan self-assigned this Sep 30, 2024
@srebhan
Copy link
Member

srebhan commented Oct 14, 2024

@diorcety could you please run make fmt to make CI happy?!

@diorcety diorcety force-pushed the branch_output_mqtt_sprig branch from 7afcde5 to 8b68b32 Compare October 14, 2024 19:34
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@diorcety
Copy link
Contributor Author

@srebhan Done

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 15, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Oct 15, 2024
@DStrand1 DStrand1 merged commit 809480e into influxdata:master Oct 15, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.33.0 milestone Oct 15, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
@diorcety @asaharn
feat(outputs.mqtt): Add sprig functions for topic name generator (inf…
d9f10b4 
…luxdata#15943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@DStrand1 DStrand1

Labels
area/mqtt feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.33.0
Development

Successfully merging this pull request may close these issues.
3 participants
@diorcety @srebhan @DStrand1