Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support building on fedora #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

grenade
Copy link

@grenade grenade commented Nov 19, 2024

cargo build fails on distros which make use of the protobuf-devel rpm package for well known google protobuf types:

  • /usr/include/google/protobuf/duration.proto
  • /usr/include/google/protobuf/timestamp.proto

this patch configures cargo to include the /usr/include path in the protoc command, allowing protoc access to the duration.proto and timestamp.proto types included by the generated_types and grpc-binary-logger-proto crates.

@hiltontj
Copy link
Collaborator

Thanks for raising this @grenade - I will need to first look into porting this change upstream, which could take some time.

In the meantime, it would be helpful if you opened an issue with the build errors that you are seeing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants