-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bind to correct port for e2e tests #25758
Conversation
This also fixes up some log messages on server start for naming
135a1ba
to
a9b074b
Compare
Just force pushed a small change to the catalog log output to match https://github.com/influxdata/influxdb_pro/pull/353 |
Ah, sadly it looks like CI does not work with this change. Tests are all hanging: https://app.circleci.com/pipelines/github/influxdata/influxdb/43145/workflows/24f834e5-ca0b-4520-9957-e9d13bc78107/jobs/405026 Will need to re-evaluate. |
Okay, looking good again after 26a82f7 |
Odd, why does that fix it? |
It was because the I think it would make sense to make |
I opened #25760 - I don't think fixing that is a high priority - I felt like getting this in to prevent CI flakes from blocking is more important. |
TestServer
now binds to port 0 so that the host will assign a random port, then scrapes the logs to get what port was assigned. This will prevent flakes in our E2E tests in CI that have been occurring from time to time.serve
command start for naming fromOSS
toCore
Closes #25423