feat: Add json lines support to query output #25698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgattozzi
requested review from
pauldix,
hiltontj,
jacksonrnewhouse and
praveen-influx
This commit adds support for JSON Lines which also lets us stream the body back to the consumer, rather than needing to buffer the entirety of the query in memory before sending it back to the user. Closes #24654
mgattozzi
force-pushed
the
mgattozzi/json-lines
branch
from
353a151 to
ab5d46d
Compare
pauldix
approved these changes
Dec 20, 2024
| TestCase { | ||
| database: Some("foo"), | ||
| query: "SELECT time, host, region, usage FROM cpu", | ||
| expected: "{\"iox::measurement\":\"cpu\",\"time\":\"1970-01-01T00:00:01\",\"host\":\"a\",\"region\":\"us-east\",\"usage\":0.9}\n\ |
There was a problem hiding this comment.
unrelated to this PR, but we should look into changing the name of iox::measurement to influxdb3::table
|
In theory it should since it's an async stream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for JSON Lines which also lets us stream the body back to the consumer, rather than needing to buffer the entirety of the query in memory before sending it back to the user.
Closes #24654