fix: change failed query with missing db to 404 #25693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the status code of a failed query that uses a db that does not exist. We now instead return a 404 rather than the default 500 code
mgattozzi
requested review from
pauldix,
hiltontj,
jacksonrnewhouse and
praveen-influx
| let serialized = serde_json::to_string(&err).unwrap(); | ||
| let body = Body::from(serialized); | ||
| Response::builder() | ||
| .status(StatusCode::NOT_FOUND) |
There was a problem hiding this comment.
Will it be easy enough to get a test added to assert the status?
There was a problem hiding this comment.
Yeah should be easy enough! Surprised we don't already have one now that I think about it
praveen-influx
approved these changes
Dec 20, 2024
|
@praveen-influx added the test so I'll merge it when it all passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the status code of a failed query that uses a db that does not exist. We now instead return a 404 rather than the default 500 code
Closes #25653