feat: create DB and Tables via REST and CLI #25687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does a few things: 1. It brings the database command naming scheme for types inline with the rest of the CLI types 2. It brings the table command naming scheme for types inline with the rest of the CLI types 3. Adds tests to check that the num of dbs is not exceeded and that you cannot create more than one database with a given name. 4. Adds tests to check that you can create a table and put data into it and querying it 5. Adds tests for the CLI for both the database and table commands 6. It creates an endpoint to create databases given a JSON blob 7. It creates an endpoint to create tables given a JSON blob With this users can now create a database or table without first needing to write to the database via the line protocol! Closes #25640 Closes #25641
mgattozzi
requested review from
pauldix,
hiltontj,
jacksonrnewhouse and
praveen-influx
pauldix
requested changes
Dec 19, 2024
influxdb3/tests/server/configure.rs
Outdated
| .send() | ||
| .await | ||
| .expect("create table call failed"); | ||
| assert_eq!(StatusCode::UNPROCESSABLE_ENTITY, resp.status()); |
There was a problem hiding this comment.
Shouldn't this be an OK? Tables without tags are valid.
| fields: Vec<(String, String)>, | ||
| ) -> Result<(), self::Error> { | ||
| if tags.is_empty() { | ||
| return Err(self::Error::EmptyTagSet); |
pauldix
approved these changes
Dec 19, 2024
mgattozzi
force-pushed
the
mgattozzi/create-db-and-table
branch
from
c2b86a1 to
4ae4bc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does a few things:
With this users can now create a database or table without first needing to write to the database via the line protocol!
Closes #25640
Closes #25641