-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: get create token and meta_cache (#25773)
* fix: get create token subcommand to work again In #25737 token creation was broken as a client would attempt to be made, but hit an unreachable branch. The fix was to just make the branch create a Client that won't do anything. We also add a test to make sure that if there is a regression we'll catch it in the future. Closes #25764 * fix: make client turn a duration into seconds/u64 This commit fixes the creation of a metadata cache made via the cli by actually sending a time in seconds as a u64 and not as a duration. With that we can now make metadata caches again when the `--max-age` flag is specified. This commit also adds a regression test for the CLI so that we can catch this again in the future.
- Loading branch information
Showing
5 changed files
with
76 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
influxdb3/tests/server/snapshots/server__cli__meta_cache_create_and_delete-2.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
source: influxdb3/tests/server/cli.rs | ||
expression: result | ||
snapshot_kind: text | ||
--- | ||
meta cache deleted successfully |
6 changes: 6 additions & 0 deletions
6
influxdb3/tests/server/snapshots/server__cli__meta_cache_create_and_delete.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
source: influxdb3/tests/server/cli.rs | ||
expression: result | ||
snapshot_kind: text | ||
--- | ||
"new cache created: {\n \"table_id\": 0,\n \"table_name\": \"cpu\",\n \"cache_name\": \"cache_money\",\n \"column_ids\": [\n 0,\n 1\n ],\n \"max_cardinality\": 20000,\n \"max_age_seconds\": 200\n}" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters