Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add __eq__ implementation to class Point #625

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

hf-kklein
Copy link
Contributor

@hf-kklein hf-kklein commented Jan 3, 2024

fixes #623

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar changed the title Add __eq__ implementation to class Point feat: Add __eq__ implementation to class Point Jan 4, 2024
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hf-kklein thanks for your PR 👍. Before we can proceed with accepting it, there are a few requirements that need to be met:

  1. Please satisfy our Checklist:
    image

@hf-kklein hf-kklein requested a review from bednar January 4, 2024 09:20
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8286f45) 90.35% compared to head (9b34a51) 90.36%.

❗ Current head 9b34a51 differs from pull request most recent head d32a35a. Consider uploading reports for the commit d32a35a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
+ Coverage   90.35%   90.36%   +0.01%     
==========================================
  Files          39       39              
  Lines        3493     3497       +4     
==========================================
+ Hits         3156     3160       +4     
  Misses        337      337              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR 👍

LGTM 🚀

@bednar bednar added this to the 1.40.0 milestone Jan 4, 2024
@bednar bednar merged commit 024c1b1 into influxdata:master Jan 4, 2024
14 checks passed
@hf-kklein hf-kklein deleted the point-equality branch January 4, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

class Point doesn't support equality comparison
3 participants