-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add __eq__
implementation to class Point
#625
Conversation
__eq__
implementation to class Point__eq__
implementation to class Point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hf-kklein thanks for your PR 👍. Before we can proceed with accepting it, there are a few requirements that need to be met:
a04394f
to
f9a8974
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #625 +/- ##
==========================================
+ Coverage 90.35% 90.36% +0.01%
==========================================
Files 39 39
Lines 3493 3497 +4
==========================================
+ Hits 3156 3160 +4
Misses 337 337 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your PR 👍
LGTM 🚀
fixes #623
Checklist
pytest tests
completes successfully