feat: Added support for custom request headers - as defined in RFC 2616 - passed by the InfluxDBClient to its (internal) RestClient. #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdrapel
changed the title
|
@powersj, title fixed, please run pipeline again? thx |
|
@kdrapel sorry for the close/opens, but trying to get circleci to launch tests. Do you have docker running locally? if so you can use the |
|
Don't have docker right under my hand to test that |
|
@kdrapel, can you please rebase your source with |
…t-csharp # Conflicts: # Client.Test/InfluxDbClientFactoryTest.cs # Client/InfluxDBClientOptions.cs # Client/Internal/ApiClient.cs
|
@kdrapel can you please satisfy the compilation error from CI:
|
|
I think my changes are incompatible with the newest RestSharp version. I discard this pull request and will maybe work on a new version soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Added support for custom request headers - as defined in RFC 2616 - passed by the InfluxDBClient to its (internal) RestClient. This is useful for example if you need to force specific security-related headers if your InfluxDB instance is behind an API management component.
Checklist
dotnet testcompletes successfully (don't have the test infrastructure with a local InfluxDB on 8086/9999)To give more insight about this change, the reason is that we had to pass our InfluxDB trafic through an Azure APIM. This requires additional headers (for subscription) that were impossible to inject with the original version.