Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chronograf] Support configurable common labels #668

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lovetoburnswhen
Copy link

@lovetoburnswhen lovetoburnswhen commented Aug 20, 2024

Adds the extraLabels property to values.yaml which allows users to provide custom labels to be added to generated resources.

This feature would be tremendously useful for environments that require certain labels to be set - the only alternative would be to fork the chart internally.


❯ helm template ./charts/chronograf -s templates/deployment.yaml --set 'extraLabels.foo=bar'                             
---
# Source: chronograf/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: release-name-chronograf
  labels:
    app: release-name-chronograf
    chart: "chronograf-1.2.7"
    release: "release-name"
    heritage: "Helm"
    helm.sh/chart: chronograf-1.2.7
    app.kubernetes.io/name: chronograf
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "1.9.4"
    app.kubernetes.io/managed-by: Helm
    foo: bar
spec:
...

  • [ ] CHANGELOG.md updated None found
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Adds the `extraLabels` property to `values.yaml` which allows users to
provide custom labels to be added to generated resources.

This feature would be tremendously useful for environments that require
certain labels to be set - the only alternative would be to fork the
chart internally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant