Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updateStrategy to Telegraf Deployment. #515

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

Foosvald
Copy link
Contributor

This makes it possible to configure the updateStrategy for the Telegraf Deployment.

In our use case and clusters we have podAntiAffinity configured for the Telegraf Deployment and to avoid pods being stuck in state Pending we also want to set updateStrategy.type: Recreate.

I've manually tried this change with:

updateStrategy: {}
updateStrategy:
  type: RollingUpdate
  rollingUpdate:
    maxUnavailable: 1
    maxSurge: 1
updateStrategy:
  type: Recreate

Which all correctly set the strategy on the Deployment.

  • CHANGELOG.md updated -> Doesn't seem to exist anymore?
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

@alespour alespour requested review from popey and alespour October 18, 2022 08:34
alespour
alespour previously approved these changes Oct 18, 2022
Copy link
Contributor

@alespour alespour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alespour alespour requested a review from tomklapka October 18, 2022 08:34
@Foosvald
Copy link
Contributor Author

Ping @alespour, @popey or @alespour, do you think you could review and hopefully approve this? It would be nice to not have to keep a local fork of the Helm chart for our builds :)

@popey
Copy link
Contributor

popey commented Oct 20, 2023

@Foosvald sorry, I'm no longer at Influx. Perhaps @powersj can help?

Copy link
Contributor

@alespour alespour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@powersj powersj merged commit bf79f8f into influxdata:master Oct 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants