-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Kapacitor): new kafka sasl oauth params #5617
Draft
vlastahajek
wants to merge
4
commits into
master
Choose a base branch
from
feat/kapacitor-kafka-sasl-oauth
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlastahajek
changed the title
feat: new kafka sasl oauth params
feat(Kapacitor): new kafka sasl oauth params
Sep 25, 2024
vlastahajek
force-pushed
the
feat/kapacitor-kafka-sasl-oauth
branch
from
September 25, 2024 09:06
76a8343
to
ad2a4af
Compare
3 tasks
jstirnaman
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just 1 formatting suggestion.
#### sasl-mechanism | ||
SASL mechanism type. Options include `GSSAPI`, `OAUTHBEARER`, `PLAIN`. | ||
SASL mechanism type. Options include `GSSAPI`, `OAUTHBEARER`, `PLAIN`, `SCRAM-SHA-256`, `SCRAM-SHA-512`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
SASL mechanism type. Options include `GSSAPI`, `OAUTHBEARER`, `PLAIN`, `SCRAM-SHA-256`, `SCRAM-SHA-512`. | |
SASL mechanism type. Options include: | |
- `GSSAPI` | |
- `OAUTHBEARER` | |
- `PLAIN` | |
- `SCRAM-SHA-256` | |
- `SCRAM-SHA-512` |
vlastahajek
force-pushed
the
feat/kapacitor-kafka-sasl-oauth
branch
from
September 26, 2024 08:30
dbdcf29
to
5bd954c
Compare
I'm marking it as a draft now not to merge it. We need to wait for the next Kapacitor release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kapacitor PR #2834 also adds new configuration params for Kafka output. This PR is extending docs for it.
(if necessary)