Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Kapacitor): new kafka sasl oauth params #5617

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vlastahajek
Copy link
Contributor

Kapacitor PR #2834 also adds new configuration params for Kafka output. This PR is extending docs for it.

@vlastahajek vlastahajek changed the title feat: new kafka sasl oauth params feat(Kapacitor): new kafka sasl oauth params Sep 25, 2024
Copy link
Contributor

@jstirnaman jstirnaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just 1 formatting suggestion.

#### sasl-mechanism
SASL mechanism type. Options include `GSSAPI`, `OAUTHBEARER`, `PLAIN`.
SASL mechanism type. Options include `GSSAPI`, `OAUTHBEARER`, `PLAIN`, `SCRAM-SHA-256`, `SCRAM-SHA-512`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SASL mechanism type. Options include `GSSAPI`, `OAUTHBEARER`, `PLAIN`, `SCRAM-SHA-256`, `SCRAM-SHA-512`.
SASL mechanism type. Options include:
- `GSSAPI`
- `OAUTHBEARER`
- `PLAIN`
- `SCRAM-SHA-256`
- `SCRAM-SHA-512`

@vlastahajek vlastahajek marked this pull request as draft September 26, 2024 19:03
@vlastahajek
Copy link
Contributor Author

I'm marking it as a draft now not to merge it. We need to wait for the next Kapacitor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants