Infinum/feature/diffable data source and animators

[ZvonimirMedak]

Description

I've added CombineTableDataSourceDelegate, TableDiffableDataSourceDelegate, TableCellAnimator and updated TableCellItem. Updated the Combine paging example with an example animation to show off how you can create your own and use it.

Checklist:

• [ x ] Have checked there is no same component already in catalog.
• [ x ] Have created a sufficient example or wrote tests for it.
• [ x ] Code is structured, well written using standard Swift coding style.
• [ x ] All public methods and properties have meaningful and concise documentation.
• [ x ] Used public modifier for all method and properties that could be changed from user of your feature, and private for internal properties.
• [ x ] Removed any reference to the project that piece of code was created in.
• [ x ] Reduced the dependencies to minimum.

[Truba]

TBH I would leave it generic.
For supporting different cell types, I would go with crating result builder for cell items 😄
I would rather go with UITableViewDiffableDataSource for iOS13+ than my custom implementation from file ⬆️ 😄

[ZvonimirMedak]

This one is tailored with some publishers we can listen to, as we have with the default TableDataSourceDelegate. What do you mean by leaving it generic? It's constrained to Hashable anyway even with the base implementation. Would love to hear more about the result builder for cell items idea 😄

[kjaklinovic]

I can't figure out what @Truba had here in mind. Maybe that you should not use AnyHashable, instead we should use generic types here like in the definition of NSDiffableDataSourceSnapshot

NSDiffableDataSourceSnapshot<SectionIdentifierType, ItemIdentifierType> : @unchecked Sendable where SectionIdentifierType : Hashable, SectionIdentifierType : Sendable, ItemIdentifierType : Hashable, ItemIdentifierType : Sendable {  }

Regarding result builders, I guess what should be done here is some result builder for sections/items
e.g. something like this

@SectionBuilder
func cellItems(models: SomeModel) -> [TableSectionItem] { 
    MySectionItem {
        for mode in models {
            MyTableCelItem(model: model)
        }
    }
    
    EmptySection(title: "someTitle")
    
    MySection2 {
        if isEnd {
            PageEndItem() 
        } else { 
            LoaderTableItem()
        }  
    }
}

¯_(ツ)_/¯ Something like this

[nikolamajcen]

I know this is quite old, but can this be revisited? Should we improve and merge this one or close?

[ZvonimirMedak]

Hi @nikolamajcen,
this brings enough improvement to be merged at this stage even though all of the comments aren't resolved. To resolve everything it would take a bit more time, and I feel like that it would complicate things without bringing much value.
If you agree, I will find some time to resolve the conflicts and we can merge it

[nikolamajcen]

Hey @ZvonimirMedak , that's fine. It does not to be instant, but it would be great if you could find someone to resolve this.