Skip to content

Commit

Permalink
Standardize Accessibility of Quote Blocks Across Browsers (#828)
Browse files Browse the repository at this point in the history
* added escaping function

* change figure role to presentation

* simplify the block to be interpreted same across the browsers
  • Loading branch information
DjidjaleskaSandra authored May 15, 2024
1 parent bac85c5 commit 341c42b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions blocks/init/src/Blocks/components/quote/quote.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
$quoteAuthorUse = Components::checkAttr('quoteAuthorUse', $attributes, $manifest);
?>

<figure class="<?php echo esc_attr($quoteClass); ?>">
<figure class="<?php echo esc_attr($quoteClass); ?>" role="presentation">
<?php
echo Components::render('icon', Components::props('icon', $attributes, [
'blockClass' => $componentClass
Expand All @@ -51,7 +51,7 @@
<?php if ($quoteAuthorUse) { ?>
<div class="<?php echo esc_attr($quoteSeparatorClass); ?>"></div>

<figcaption class="<?php echo esc_attr($quoteCaptionClass); ?>">
<figcaption class="<?php echo esc_attr($quoteCaptionClass); ?>" role="presentation">
<?php
echo Components::render('paragraph', Components::props('author', $attributes, [
'blockClass' => $componentClass
Expand Down

0 comments on commit 341c42b

Please sign in to comment.