fix: sql query with elasticsearch version 6.x #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luohoufu
changed the title
silenceqi
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This pull request includes changes to the
HandleProxyActionfunction in themodules/elastic/api/proxy.gofile to handle different Elasticsearch distributions and versions more effectively. The most important changes include adding version handling for Elasticsearch and ensuring the correct path is used based on the version.Enhancements to Elasticsearch version handling:
modules/elastic/api/proxy.go: Added retrieval of the Elasticsearch version number and adjusted the request path based on the version, ensuring compatibility with versions before and after 7.0.0. [1] [2]Rationale for this change
Standards checklist