Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enhance LDAP authentication logging #156

Merged
merged 3 commits into from
Feb 20, 2025
Merged

chore: Enhance LDAP authentication logging #156

merged 3 commits into from
Feb 20, 2025

Conversation

luohoufu
Copy link
Contributor

@luohoufu luohoufu commented Feb 20, 2025

What does this PR do

This pull request includes changes to improve logging and simplify the iteration over realms in the authentication and authorization processes. The most important changes include adding debug logging for empty LDAP groups and using the realm type instead of the index for logging in the Authenticate and Authorize functions.

Improvements to logging:

Codebase simplification:

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@luohoufu luohoufu changed the title chore: improve logs for ldap auth chore: Enhance LDAP Authentication Logging Feb 20, 2025
@luohoufu luohoufu changed the title chore: Enhance LDAP Authentication Logging chore: Enhance LDAP authentication logging Feb 20, 2025
@silenceqi silenceqi merged commit df33fa0 into main Feb 20, 2025
5 checks passed
@silenceqi silenceqi deleted the ldap_logs_pr branch February 20, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants