chore: Enhance LDAP authentication logging #156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This pull request includes changes to improve logging and simplify the iteration over realms in the authentication and authorization processes. The most important changes include adding debug logging for empty LDAP groups and using the realm type instead of the index for logging in the
Authenticate
andAuthorize
functions.Improvements to logging:
modules/security/realm/authc/ldap/ldap.go
: Added debug logging for cases where the LDAP groups are empty in themapLDAPRoles
function.Codebase simplification:
modules/security/realm/realm.go
: Replaced the index variable with the realm type in debug logging for theAuthenticate
function.modules/security/realm/realm.go
: Replaced the index variable with the realm type in debug logging for theAuthorize
function.Rationale for this change
Standards checklist