Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused badger and default agent settings #9

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

luohoufu
Copy link
Contributor

What does this PR do

remove unused badger and default agent settings

Rationale for this change

This pull request includes changes to the agent.yml file to update the configuration for the agent. The most important changes involve removing the badger configuration and adding new settings for the agent's IP pattern, labels, and tags.

Configuration changes:

  • agent.yml: Removed the badger configuration, which included settings for mem_table_size, value_log_max_entries, value_log_file_size, and value_threshold.
  • agent.yml: Added new settings for the agent, including major_ip_pattern, labels with an environment label set to "prod", and tags with values linux and x86.

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

Copy link
Member

@medcl medcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default value maybe not the user wanted

@luohoufu luohoufu requested a review from medcl January 22, 2025 12:11
@medcl medcl merged commit d79cf30 into main Jan 23, 2025
6 checks passed
@medcl medcl deleted the default_config_pr branch January 23, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants