FI-3241: Verify runnable id length #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
=======================================
Coverage 84.07% 84.08%
=======================================
Files 261 261
Lines 11386 11392 +6
Branches 1251 1252 +1
=======================================
+ Hits 9573 9579 +6
Misses 1803 1803
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Shaumik-Ashraf
approved these changes
Oct 23, 2024
vanessuniq
approved these changes
Oct 23, 2024
Jammjammjamm
force-pushed
the
fi-3241-verify-runnable-id-length
branch
from
649a160
to
439c8b2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some runnable ids were becoming longer than the length limit on the columns for runnable ids in the database. SQLite doesn't actually enforce those limits, so this issue wouldn't be noticed until trying to run on QA/prod. This branch checks runnable ids on creation so that they will be noticed immediately.
Testing Guidance
You can do something like change the id of the demo suite to
'a' * 256, and Inferno will fail to start.