Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch undefined method for nil on validator 500 response #530

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

Shaumik-Ashraf
Copy link
Contributor

Summary

image

Testing Guidance

See that this passes CI and run a dev suite

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (38387f4) to head (e1000a4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #530   +/-   ##
=======================================
  Coverage   79.86%   79.86%           
=======================================
  Files         253      253           
  Lines       13351    13351           
  Branches     1290     1289    -1     
=======================================
  Hits        10663    10663           
  Misses       1939     1939           
  Partials      749      749           
Flag Coverage Δ
backend 91.84% <100.00%> (ø)
frontend 74.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vanessuniq
Copy link
Contributor

Neat, thanks! Just ran into that bug as well. Glad it resolved in no time.

@Shaumik-Ashraf Shaumik-Ashraf merged commit 8bce37b into main Sep 22, 2024
10 checks passed
@Shaumik-Ashraf Shaumik-Ashraf deleted the debug-2024-09-22 branch September 22, 2024 15:47
@rpassas rpassas mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants