Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3112: Fixed JWKS Template Path Used in Unit Tests #526

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

vanessuniq
Copy link
Contributor

Summary

Reading the jwks.json template in spec using relative path raised a no file error when using the gem in test kit test environment. This PR updates the jwks path to the correct absolute path.

Testing Guidance

Test by pointing inferno_core gem to this branch and ensure no error when executing rspec.

Signed-off-by: Vanessa Fotso <[email protected]>
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (d4a676c) to head (7addd7a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #526   +/-   ##
=======================================
  Coverage   79.86%   79.86%           
=======================================
  Files         253      253           
  Lines       13351    13351           
  Branches     1290     1290           
=======================================
  Hits        10663    10663           
  Misses       1939     1939           
  Partials      749      749           
Flag Coverage Δ
backend 91.84% <ø> (ø)
frontend 74.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vanessuniq vanessuniq merged commit 369bc60 into main Sep 18, 2024
10 checks passed
@rpassas rpassas mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants