Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2990: Fix typo in Request Details Modal #519

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

AlyssaWang
Copy link
Collaborator

Summary

Fixes a typo that prevented the request body from appearing properly in the RequestDetailsModal.

Testing Guidance

For a test with a request body, check the Details modal to ensure that it appears.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.65%. Comparing base (c91b44c) to head (de2de27).
Report is 1 commits behind head on main.

Files Patch % Lines
...mponents/RequestDetailModal/RequestDetailModal.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   79.72%   79.65%   -0.07%     
==========================================
  Files         249      249              
  Lines       13177    13177              
  Branches     1290     1289       -1     
==========================================
- Hits        10505    10496       -9     
- Misses       1922     1932      +10     
+ Partials      750      749       -1     
Flag Coverage Δ
backend 91.66% <ø> (ø)
frontend 74.54% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@emichaud998 emichaud998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just tested it out with the test kit I originally found the problem in and it fixed it!

@AlyssaWang AlyssaWang merged commit e1b8fb6 into main Aug 23, 2024
9 of 10 checks passed
@AlyssaWang AlyssaWang deleted the FI-2990-request-body branch August 23, 2024 15:01
@rpassas rpassas mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants