FI-2468: Enable different test results in resume_test_route #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jammjammjamm
reviewed
Feb 7, 2024
lib/inferno/repositories/results.rb
Outdated
| @@ -140,6 +140,18 @@ def pass_waiting_result(result_id, message = nil) | |||
| update(result_id, result: 'pass', result_message: message) | |||
| end | |||
|
|
|||
| def fail_waiting_result(result_id, message = nil) | |||
There was a problem hiding this comment.
We should replace all these with a generic update_waiting_result method. It looks like the existing pass_waiting_result and cancel_waiting_result were only used in one place, so it should be an easy change.
There was a problem hiding this comment.
80b77b8 While at it, I renamed the method to update_result since its behavior is not specific to a waiting result
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
+ Coverage 77.29% 77.32% +0.02%
==========================================
Files 225 225
Lines 11215 11224 +9
Branches 1053 1053
==========================================
+ Hits 8669 8679 +10
+ Misses 1945 1944 -1
Partials 601 601
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jammjammjamm
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows different URLs to trigger different test results for a waiting test by adding keyword param
resulttoresume_test_route.Testing Guidance
Run the demo suite Wait Group and test the various URLs.