FI-2463 large request fix #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arscan
force-pushed
the
fi-2463-large-request-fix
branch
from
7d15bd9
to
d5a5e61
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
==========================================
- Coverage 77.32% 77.29% -0.03%
==========================================
Files 225 225
Lines 11211 11215 +4
Branches 1052 1053 +1
==========================================
Hits 8669 8669
- Misses 1941 1945 +4
Partials 601 601
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
arscan
force-pushed
the
fi-2463-large-request-fix
branch
from
eaebcc4
to
2773c70
Compare
Jammjammjamm
approved these changes
Feb 5, 2024
arscan
force-pushed
the
fi-2463-large-request-fix
branch
from
2773c70
to
d37cea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Large payloads in the body of API calls cause the logger to break due to how puma handles very large payloads differently than smaller payloads when parsing.
Testing Guidance
Ensure that important test kits (e.g. g10) still work properly. Replicating large input payloads do not break is more challenging, ask team for an example.