Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2347: Set radio default input #416

Merged
merged 1 commit into from
Dec 9, 2023
Merged

FI-2347: Set radio default input #416

merged 1 commit into from
Dec 9, 2023

Conversation

AlyssaWang
Copy link
Collaborator

@AlyssaWang AlyssaWang commented Dec 7, 2023

Summary

Fixes a bug where radio button default values weren't being set properly.

Testing Guidance

Make sure the default radio button value in SMART STU2 for client_auth_type is getting set when mounted.

Detailed Testing Procedure

  1. Clone inferno-core.
  2. In the Gemfile, uncomment this line: gem 'onc_certification_g10_test_kit'.
  3. In demo_suite.rb, uncomment this line: require 'onc_certification_g10_test_kit'.
  4. Make sure Docker is running and set up Inferno Core locally following the Running Inferno Core for Development Purposes instructions in the README. Navigate to localhost:4567/inferno/.
  5. In the UI, run all tests for SMART STU2 -- you can use filler values for required fields and cancel out of the wait test.
  6. Open the developer console (right click -> Inspect) and navigate to the Networks tab.
  7. Look for the test_runs API call and go to the Payload tab. Inputs and their values will be printed. The radio buttons should be showing empty values for the client_auth_type or Client Authentication Method field. This is confirming that the bug is appearing.
  8. Switch to the FI-2347-radio-default branch and retry steps 5-7. The same fields should now have values. This is confirming that the bug is fixed.
Screenshot 2023-12-07 at 10 00 30 PM

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0181b6d) 77.10% compared to head (74d4225) 77.06%.

Files Patch % Lines
...ent/src/components/InputsModal/InputRadioGroup.tsx 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
- Coverage   77.10%   77.06%   -0.05%     
==========================================
  Files         218      218              
  Lines       10872    10878       +6     
  Branches     1018     1018              
==========================================
  Hits         8383     8383              
- Misses       1911     1917       +6     
  Partials      578      578              
Flag Coverage Δ
backend 93.82% <ø> (ø)
frontend 69.70% <14.28%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alisawallace alisawallace Dec 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that bug was fixed when repeating the SMART App Launch steps that revealed the bug.

@AlyssaWang AlyssaWang merged commit 0c5c15e into main Dec 9, 2023
9 of 10 checks passed
@AlyssaWang AlyssaWang deleted the FI-2347-radio-default branch December 9, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants