Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-1980: Refactor selection components #361

Merged
merged 18 commits into from
Jun 23, 2023
Merged

FI-1980: Refactor selection components #361

merged 18 commits into from
Jun 23, 2023

Conversation

AlyssaWang
Copy link
Collaborator

@AlyssaWang AlyssaWang commented May 15, 2023

Summary

Separated selection components from pages and cleaned up page styles as a precursor to updating page layouts

Testing Guidance

Layout should work for all views (web, small web, mobile) and selections should work as normal.

Screenshot 2023-06-23 at 1 58 09 PM Screenshot 2023-06-23 at 1 58 26 PM

@AlyssaWang AlyssaWang requested a review from arscan May 15, 2023 15:30
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +21.02 🎉

Comparison is base (ca2b7e4) 73.44% compared to head (8bd7299) 94.46%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #361       +/-   ##
===========================================
+ Coverage   73.44%   94.46%   +21.02%     
===========================================
  Files         198      116       -82     
  Lines        9729     3090     -6639     
  Branches      815      377      -438     
===========================================
- Hits         7145     2919     -4226     
+ Misses       2153      171     -1982     
+ Partials      431        0      -431     
Flag Coverage Δ
backend 94.46% <ø> (ø)
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 82 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tstrass tstrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Just one minor thing I noticed and the branch needs to be brought up to date. Also looks like it's failing codecov.

@AlyssaWang AlyssaWang requested a review from tstrass June 22, 2023 20:57
@arscan
Copy link
Contributor

arscan commented Jun 23, 2023

👍 the slight tweaks to padding and grey colors look good!

@AlyssaWang AlyssaWang merged commit f0d1e42 into main Jun 23, 2023
@AlyssaWang AlyssaWang deleted the lp-layout branch June 23, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants