-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI-1980: Refactor selection components #361
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
===========================================
+ Coverage 73.44% 94.46% +21.02%
===========================================
Files 198 116 -82
Lines 9729 3090 -6639
Branches 815 377 -438
===========================================
- Hits 7145 2919 -4226
+ Misses 2153 171 -1982
+ Partials 431 0 -431
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Just one minor thing I noticed and the branch needs to be brought up to date. Also looks like it's failing codecov.
👍 the slight tweaks to padding and grey colors look good! |
Summary
Separated selection components from pages and cleaned up page styles as a precursor to updating page layouts
Testing Guidance
Layout should work for all views (web, small web, mobile) and selections should work as normal.