remove bang from find_by_short_id name

lib/inferno/apps/cli/execute.rb

@@ -168,16 +168,16 @@ def dispatch_job(test_run)
       def groups
         return [] if options[:groups].blank?
 
-        @groups ||= options[:groups]&.map { |short_id| find_by_short_id!(test_groups_repo, short_id) }
+        @groups ||= options[:groups]&.map { |short_id| find_by_short_id(test_groups_repo, short_id) }
       end
 
       def tests
         return [] if options[:tests].blank?
 
-        @tests ||= options[:tests]&.map { |short_id| find_by_short_id!(tests_repo, short_id) }
+        @tests ||= options[:tests]&.map { |short_id| find_by_short_id(tests_repo, short_id) }
       end
 
-      def find_by_short_id!(repo, short_id)
+      def find_by_short_id(repo, short_id)
         repo.all.each do |entity|
           return entity if short_id == entity.short_id && suite.id == entity.suite.id
         end

spec/inferno/apps/cli/execute_spec.rb

@@ -113,10 +113,10 @@
     end
   end
 
-  describe '#find_by_short_id!' do
+  describe '#find_by_short_id' do
     it 'raises standard error when entity not found by short id' do
       expect do
-        instance.find_by_short_id!(Inferno::Repositories::Tests.new, 'does_not_exist')
+        instance.find_by_short_id(Inferno::Repositories::Tests.new, 'does_not_exist')
       end.to raise_error(StandardError)
     end
   end