Skip to content

Commit

Permalink
FI-2086: fix errors on webpack shutdown (#389)
Browse files Browse the repository at this point in the history
* Changed from system call to exec call in main

* Replaced npm start command with direct webpack invocation

Because npm is not a process manager, it does not propagate SIGINTs to the scripts it starts
(webpack in this case) - thus, doing Ctrl+C on the Foreman process will kill the npm process
but not the webpack process.  Replacing the "npm run start" command with whatever is
listed under "start" in package.json bypasses this signal handling discrepancy.

* Removed commented out code
  • Loading branch information
alisawallace authored Sep 11, 2023
1 parent 08ec136 commit 8d88911
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Procfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
web: bundle exec puma
worker: bundle exec sidekiq -r ./worker.rb
webpack: npm run start
webpack: ./node_modules/.bin/webpack serve --config ./webpack.config.js --mode=development
2 changes: 1 addition & 1 deletion lib/inferno/apps/cli/main.rb
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def start
command = "rerun \"#{command}\" --background"
end

system command
exec command
end

desc 'suites', 'List available test suites'
Expand Down

0 comments on commit 8d88911

Please sign in to comment.