-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI-3584: Allow User Provided Questionnaire Package Responses #44
base: main
Are you sure you want to change the base?
FI-3584: Allow User Provided Questionnaire Package Responses #44
Conversation
… provided response Signed-off-by: Vanessa Fotso <[email protected]>
…as provided or not. mainly validating origin source and required answers Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
Do you have an example questionnaire package response that you've used with this functionality? Walking through an example of how to use it would help with the review. |
I tested with the bundle we use for the Respiratory Assist Device workflow and also this output parameter from the IG |
Signed-off-by: Vanessa Fotso <[email protected]>
I think I mostly know what I need to do, but any testing guidance for this? Edit: I guess Karl asked a related question above so I'll just go off of that if there's nothing else. |
...avinci_dtr_test_kit/client_groups/dinner_static/dtr_full_ehr_questionnaire_workflow_group.rb
Outdated
Show resolved
Hide resolved
..._dtr_test_kit/client_groups/full_ehr/dtr_full_ehr_questionnaire_response_correctness_test.rb
Outdated
Show resolved
Hide resolved
..._dtr_test_kit/client_groups/full_ehr/dtr_full_ehr_questionnaire_response_correctness_test.rb
Outdated
Show resolved
Hide resolved
Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
…n, ensuring it can be retrieved Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
Seeing this in practice, I don’t think that changing the dinner static tests to accommodate user-specified $questionnapire-package responses is the right approach. In the SMART tests in particular, we’re able to verify significantly more detail when we know the Questionnaire and the data available to pre-populate it and changing the tests to assume that we don’t know that level of detail is a big step back. I think instead, we should make these completely new tests that test the smaller scope in the basic workflows section and move the dinner static ones elsewhere, like into the Questionnaire Functionality Coverage section. In addition to that, I think that even though we can’t validate that the client does things like pre-populate correctly, I think we can and should change that all of the “source” values are present: auto, manual, and override. |
Summary
This update introduces the ability for users to provide a custom questionnaire package response for the Static Questionnaire workflow test, applicable to both Full EHR and SMART APP Suite. The test logic has been updated to handle the validation of the provided QuestionnaireResponse, and the attestation statements have been adjusted to reflect these changes.
Test Guidance