FI-3509: Metadata OAuth URIs #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnaden
requested changes
Dec 18, 2024
...dtr_test_kit/client_groups/resp_assist_device/dtr_resp_questionnaire_package_request_test.rb
Outdated
Show resolved
Hide resolved
...t_kit/client_groups/dinner_static/dtr_smart_app_dinner_questionnaire_package_request_test.rb
Outdated
Show resolved
Hide resolved
tstrass
force-pushed
the
fi-3509-ri-integration
branch
from
8c35cda to
a46dedd
Compare
karlnaden
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Works as expected. There are some additional details in the capability statement that don't align well with how Inferno is using the reference server for a simulation of DTR (not us core as the capability statement currently states), but I don't think that is in scope for this change. I created FI-3602 to track those additional updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Questionnaire to default fhirContext inputsThis came out of the investigation into launching the DTR reference implementation against Inferno. The RI uses the metadata endpoint to determine the OAuth URIs instead of using /.well-known/smart-configuration. This goes against guidance in the IG, but it's conceivable other client systems could do the same.
Note there are other data elements in the metadata response that aren't representative of how a DTR client can interact with the test suite, but I don't see much benefit from filtering it down further/overwriting more stuff. But at some point it might the most sense to just construct our own CapabilityStatement for the test suite instead of proxy to the reference server.
Testing Guidance
Run the SMART App suite, make a /metadata request with Postman, confirm the OAuth URIs are as expected.