FI-3463: DTR Light EHR: test supported payer endpoint #42

degradification · 2024-12-16T18:28:34Z

Description

This ticket adds a test for DTR Light EHR requirement 102 to the DTR Light EHR suite. This defines an endpoint, which Inferno can respond to requests and return conformant information.

Important Changes

lib/davinci_dtr_test_kit/client_groups/light_ehr/dtr_light_ehr_supported_endpoints_group.rb

Defined the supported endpoints group

lib/davinci_dtr_test_kit/client_groups/light_ehr/dtr_light_ehr_supported_payer_endpoint_test.rb

Defined the test that the app can access the supported payer endpoint via a GET request & checks the header
lib/davinci_dtr_test_kit/dtr_light_ehr_suite.rb
Defined the route for the new endpoint

lib/davinci_dtr_test_kit/dtr_light_ehr_suite.rb

Added requires
Defined the suite_endpoint
Added the group for the supported endpoints

lib/davinci_dtr_test_kit/endpoints/mock_payer/light_ehr_supported_payer_endpoint.rb

A GET route /supported-payers was defined to return a JSON response with a list of payers, each payer contains id & name)
Checks the header to see if it is application/json

spec/davinci_dtr_test_kit/dtr_light_ehr_supported_payer_endpoint_test_spec.rb

Implements unit tests for LightEHRSupportedPayerEndpoint
Test simulates a request to the endpoint and checks that the test waits for the request and then passes if received

lib/davinci_dtr_test_kit/tags.rb

Added tag for light ehr endpoint

lib/davinci_dtr_test_kit/urls.rb

Added supported payer path & url

Testing Recommendations

Make sure all unit tests pass including the ones that were added to this pull request, and the application runs as expected. Run the Light EHR tests to test both expected successes and expected failures. Run the SMART App Test Suite tests to test both expected success and expected failures.

Checklists

Submitter:

This MR describes why these changes were made.
This MR is into the correct branch (usually 'main').
Comment added to the relevant Jira ticket(s) with a link to this MR.
The relevant Jira ticket has been moved to 'Peer Review' (may be N/A if a Jira ticket is associated with multiple MRs)
Code diff has been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.).
Ensure automated tests pass successfully.

Final Merger

The necessary number of reviews/approvals have been received on this PR and all checklists have been completed.
The relevant Jira ticket has been moved to 'Done' (may N/A if a Jira ticket is associated with multiple MRs)

-Updated route definition -TODO: Fix endpoint configuration

-Added test for supported payer

-TODO: Ensure the endpoint can be while unit testing

vanessuniq

Move the url input from the suite level to the specific groups that require it, so that it is not required for the supported enpoint group.

vanessuniq · 2024-12-19T21:40:14Z

lib/davinci_dtr_test_kit/client_groups/light_ehr/dtr_light_ehr_supported_payer_endpoint_test.rb

+    id :dtr_light_ehr_supported_payer_endpoint
+    title 'Client can retrieve payers from supported payer endpoint'
+    description %(
+      Inferno, will wait for a request to return the payer details from the supported endpoint.


This should be a description of what this test checks. something like, 'This test verifies that the app can successfully access the supported payer endpoint via a GET request, including an Accept header set to application/json'.

vanessuniq · 2024-12-19T21:50:45Z

lib/davinci_dtr_test_kit/client_groups/light_ehr/dtr_light_ehr_supported_endpoints_group.rb

+module DaVinciDTRTestKit
+  class DTRLightEhrSupportedEndpointsGroup < Inferno::TestGroup
+    id :dtr_light_ehr_supported_endpoints
+    title 'DTR Supported Endpoints'


Suggested change

title 'DTR Supported Endpoints'

title 'Supported Endpoints'

vanessuniq · 2024-12-19T21:52:38Z

lib/davinci_dtr_test_kit/dtr_light_ehr_suite.rb

+    group do
+      title 'DTR Light EHR Supported Endpoints'
+      description %(This test group tests system for their conformance to
+      the supported endpoint capabilities as defined by the DaVinci Documentation
+      Templates and Rules (DTR) v2.0.1 Implementation Guide Light DTR EHR
+      Capability Statement.
+
+      )
+
+      group from: :dtr_light_ehr_supported_endpoints
+    end


You don’t need to nest group from: :dtr_light_ehr_supported_endpoints within another group. You can simply use group from: :dtr_light_ehr_supported_endpoints directly. Update the dtr_light_ehr_supported_endpoints_group.rb file with this description.

vanessuniq · 2024-12-19T21:57:58Z

lib/davinci_dtr_test_kit/endpoints/mock_payer/light_ehr_supported_payer_endpoint.rb

@@ -0,0 +1,45 @@
+require_relative '../mock_payer'


This should be removed, since no functionality from that module is being used here.

vanessuniq · 2024-12-19T21:58:18Z

lib/davinci_dtr_test_kit/endpoints/mock_payer/light_ehr_supported_payer_endpoint.rb

+module DaVinciDTRTestKit
+  module MockPayer
+    class LightEHRSupportedPayerEndpoint < Inferno::DSL::SuiteEndpoint
+      include MockPayer


remove this as well

vanessuniq · 2024-12-19T22:05:53Z

lib/davinci_dtr_test_kit/endpoints/mock_payer/light_ehr_supported_payer_endpoint.rb

+      def update_result
+        results_repo.update_result(result.id, 'pass') unless test.config.options[:accepts_multiple_requests]
+      end


Modify this logic so that it fails if the Accept header is not application/json and passes otherwise.

vanessuniq · 2024-12-19T22:19:29Z

spec/davinci_dtr_test_kit/dtr_light_ehr_supported_endpoints_group_spec.rb

@@ -0,0 +1,65 @@
+require_relative '../request_helper'
+
+RSpec.describe DaVinciDTRTestKit::DTRLightEhrSupportedEndpointsGroup do


write spec for the Test directly instead of the group.

…ndpoint

-TODO: Address the endpoint configuration for spec file

Initial endpoint definition with sinatra-base

db1e90d

degradification self-assigned this Dec 16, 2024

degradification requested a review from karlnaden December 16, 2024 18:31

degradification added 3 commits December 16, 2024 14:31

Updated ACCEPT requirement

72cc18f

Updated endpoints to use Inferno constructs

6a7a850

-Updated route definition -TODO: Fix endpoint configuration

Updated Supported Payer Endpoint to properly perform requests

31cec0c

-Added test for supported payer

degradification requested a review from vanessuniq December 19, 2024 14:43

Updated descriptions/fixed typos & adjusted the unit test path

a9543e0

-TODO: Ensure the endpoint can be while unit testing

vanessuniq requested changes Dec 19, 2024

View reviewed changes

degradification added 2 commits December 26, 2024 14:14

Merge branch 'main' into fi-3463-dtr-light-ehr-test-supported-payer-e…

209fa37

…ndpoint

Addressed MR comments

078f816

-TODO: Address the endpoint configuration for spec file

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FI-3463: DTR Light EHR: test supported payer endpoint #42

FI-3463: DTR Light EHR: test supported payer endpoint #42

degradification commented Dec 16, 2024 •

edited

Loading

vanessuniq left a comment

vanessuniq Dec 19, 2024

vanessuniq Dec 19, 2024

vanessuniq Dec 19, 2024

vanessuniq Dec 19, 2024

vanessuniq Dec 19, 2024

vanessuniq Dec 19, 2024

vanessuniq Dec 19, 2024

		@@ -0,0 +1,65 @@
		require_relative '../request_helper'

		RSpec.describe DaVinciDTRTestKit::DTRLightEhrSupportedEndpointsGroup do

FI-3463: DTR Light EHR: test supported payer endpoint #42

Are you sure you want to change the base?

FI-3463: DTR Light EHR: test supported payer endpoint #42

Conversation

degradification commented Dec 16, 2024 • edited Loading

Description

Important Changes

Testing Recommendations

Checklists

vanessuniq left a comment

Choose a reason for hiding this comment

vanessuniq Dec 19, 2024

Choose a reason for hiding this comment

vanessuniq Dec 19, 2024

Choose a reason for hiding this comment

vanessuniq Dec 19, 2024

Choose a reason for hiding this comment

vanessuniq Dec 19, 2024

Choose a reason for hiding this comment

vanessuniq Dec 19, 2024

Choose a reason for hiding this comment

vanessuniq Dec 19, 2024

Choose a reason for hiding this comment

vanessuniq Dec 19, 2024

Choose a reason for hiding this comment

degradification commented Dec 16, 2024 •

edited

Loading