Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3514: Bug fix for inputs for different workflows #34

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

tstrass
Copy link
Contributor

@tstrass tstrass commented Dec 2, 2024

Summary

Differentiate inputs for different workflows so that you can run static dinner, adaptive dinner, and respiratory assist device workflows in the same test run.

I also threw in some formatting fixes on those inputs. There were a bunch of tick marks intended for code style, but that style doesn't get applied in the frontend.

Testing Guidance

Click "Run All Tests" at the SMART App suite level. Put something different for each set of inputs, and verify with Postman that the right things get returned at the right time.

@tstrass tstrass requested a review from karlnaden December 2, 2024 21:39
@tstrass tstrass self-assigned this Dec 2, 2024
@tstrass tstrass changed the title FI-3514: Static and Adaptive inputs bug fix FI-3514: Bug fix for inputs for different workflows Dec 2, 2024
Copy link
Contributor

@karlnaden karlnaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the postman-based demo on all three sets when running together and it worked as expected.

Unit tests would be good to get in place for the Smart App tests at some point, but I don't think now is the right time.

@tstrass tstrass merged commit 5dfceac into main Dec 3, 2024
3 checks passed
@tstrass tstrass deleted the fi-3514-bugfix-static-adaptive-inputs branch December 3, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants