-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI-3161: ID Token #24
Conversation
47087d3
to
39bcfc9
Compare
Pushed two commits to fix and improve various things with OpenID and verified with the SMART Launch test kit. Ready for review again @karlnaden |
...dtr_test_kit/client_groups/resp_assist_device/dtr_resp_questionnaire_package_request_test.rb
Outdated
Show resolved
Hide resolved
I need better instructions for how to run this using the postman collection. Specifically, the authorize and token requests I wasn't able to get to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
@karlnaden In what way were they not working? You should only need to set the base_url variable and then send the requests when the suite is in a wait. If you saw a 404 on the Authorize request(s), that's just because the response to Authorize is a redirect, and Postman attempts to follow the redirect. You can see the 302 if you look in the console. |
Summary
openid
andfhirUser
scopes.I chose to always return the ID token, regardless of whether the SUT requested theopenid
andfhirUser
scopes. This is because it would add complexity to check which scopes they requested, and I didn't see any harm in always returning an ID Token.Update: I added consideration of OpenID scopes to avoid potentially misleading the tester: 221eaf1
This just hard codes in the Practitioner from the DTR bundle on the reference server
This doesn't mock any kind of identity provider
Testing Guidance