Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FI-3270: CI, Rubocop #23

Merged
merged 9 commits into from
Oct 24, 2024
Merged

FI-3270: CI, Rubocop #23

merged 9 commits into from
Oct 24, 2024

Conversation

tstrass
Copy link
Contributor

@tstrass tstrass commented Oct 23, 2024

Summary

  • Add CI
  • Fix all existing rubocop violations, including refactoring various things to satisfy complexity rules

Testing Guidance

  • Run all the suites to check expected results

@tstrass tstrass requested a review from karlnaden October 23, 2024 14:24
@tstrass tstrass self-assigned this Oct 23, 2024
karlnaden
karlnaden reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@karlnaden karlnaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed our demos and they work as expected, but I haven't had time to setup and run everything through completely. Looking good so far, will try to do that tomorrow.

@karlnaden karlnaden self-requested a review October 24, 2024 13:02
karlnaden
karlnaden approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@karlnaden karlnaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tstrass tstrass merged commit 29c67d4 into main Oct 24, 2024
3 checks passed
@tstrass tstrass deleted the fi-3270-add-ci branch October 24, 2024 16:27
@rpassas rpassas mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlnaden karlnaden karlnaden approved these changes

Assignees

@tstrass tstrass

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tstrass @karlnaden @rpassas