Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2] Deferred Props #130

Closed
wants to merge 6 commits into from
Closed

[V2] Deferred Props #130

wants to merge 6 commits into from

Conversation

PedroAugustoRamalhoDuarte
Copy link
Contributor

@PedroAugustoRamalhoDuarte PedroAugustoRamalhoDuarte commented Oct 4, 2024 •
edited
Loading

Initial PR to implement Deferred Props in rails

TODO

  • Create an interface to handle new IgnoreInFirstLoadProps methods
  • Create InertiaRails.defer method
  • Group feature for InertiaRails.defer
  • Share the Deffered Props inside deferredProps inertia response

closes #129

inspired by:

@PedroAugustoRamalhoDuarte PedroAugustoRamalhoDuarte marked this pull request as draft October 4, 2024 18:57
@PedroAugustoRamalhoDuarte PedroAugustoRamalhoDuarte changed the title Draft: [V2] Deferred Props [V2] Deferred Props Oct 4, 2024
@PedroAugustoRamalhoDuarte PedroAugustoRamalhoDuarte marked this pull request as ready for review October 4, 2024 20:30
@buhrmi
Copy link
Contributor

buhrmi commented Oct 7, 2024

i will test it as soon as the 2.0 beta is out

skryukov
skryukov reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@skryukov skryukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PedroAugustoRamalhoDuarte 🙌 I left a couple of comments, otherwise it looks really good!

lib/inertia_rails/ignore_first_load_prop.rb Show resolved Hide resolved
lib/inertia_rails/renderer.rb Show resolved Hide resolved
@skryukov skryukov mentioned this pull request Oct 10, 2024
Merged
@PedroAugustoRamalhoDuarte
Copy link
Contributor Author

@skryukov i don't know with this PR make sense alone right now that is merged into v2

@PedroAugustoRamalhoDuarte
Copy link
Contributor Author

Closing in favor of #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skryukov skryukov skryukov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V2: Implementing Deferred props
3 participants
@PedroAugustoRamalhoDuarte @buhrmi @skryukov