Skip to content
This repository has been archived by the owner on Jun 12, 2020. It is now read-only.

Commit

Permalink
add PR template
Browse files Browse the repository at this point in the history
  • Loading branch information
greglinch committed Dec 17, 2019
1 parent 2dcc351 commit fa1dd59
Showing 1 changed file with 35 additions and 0 deletions.
35 changes: 35 additions & 0 deletions docs/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
[TECH-<id> <name here>](https://industrydive.atlassian.net/browse/TECH-<id>)

### Non-technical Context

### Technical Context

### Reproduction Steps

### Manual Testing Instructions

### QA Checklist

#### Developer

- [ ] Ensure code complies with the [style guide](https://industrydive.atlassian.net/wiki/spaces/TECH/pages/639500407/Tech+Team+s+Style+Guides)
- [ ] Devise edge cases to test the bug fix or feature being merged
- [ ] Make sure the code is clean and understandable
- [ ] Ensure code is not overly inefficient
- [ ] Ensure documentation is understandable and accurate, including:
- [ ] Code comments and doc strings
- [ ] Technical documentation


#### Reviewer

- [ ] Ensure code complies with the [style guide](https://industrydive.atlassian.net/wiki/spaces/TECH/pages/639500407/Tech+Team+s+Style+Guides)
- If there are few or minor issues, add inline GitHub comments
- If there are many issues or it seems like the developer did not follow the style guide, leave a comment asking them to do so
- [ ] Devise edge cases to test the bug fix or feature being merged
- [ ] Make sure the code is clean and understandable
- [ ] Ask for inline comments on unclear sections
- [ ] Ensure code is not overly inefficient
- [ ] Ensure documentation is understandable and accurate, including:
- [ ] Code comments and doc strings
- [ ] Technical documentation

0 comments on commit fa1dd59

Please sign in to comment.