Modified to be buildable for libcamera 0.1.0 #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete original file
delete original file
pumomochin
changed the title
|
Any chance we can completely remove the embedded libcamera and rely on external library? |
|
Thank you for your reply. The pointed-out embedded libcamera is not found in this project; this project may depend on the external library, which is libcamera. I didn't build for another version of libcamera. However, my pull request for applying to the libcamera update is reasonable because this external libcamera update only removed the alias of the definition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indi-libcamera: As for removed alias of StreamRoles in libcamera 0.1.0, these code are compiled well for this environment, which is on raspberry pi 4 with imx477.